Is there a specific reason why you have higher confidence that the 1801 XDF is more accurate?
Announcement
Collapse
No announcement yet.
CSL '0401' Program Binary Disassembly Notes
Collapse
X
-
Originally posted by R3VM3UP View PostIs there a specific reason why you have higher confidence that the 1801 XDF is more accurate?
Not sure if an 1801 XDF actually exists btw, if it does it's probably one that was built off the original 0901 work.
Sent from my iPhone using Tapatalk2005 ///M3 SMG Coupe Silbergrau Metallic/CSL bucket seats
Build Thread: https://nam3forum.com/forums/forum/m...e46-m3-journal
Comment
-
I've written up a wiki page here: https://github.com/karter16/CSL_0401...works#overview which describes in detail how the MAP sensor is used to calculate RF. It includes explanation, details of all variables and parameters along with a full code listing and code walkthrough of the functions that calculate RF and the integral controller component.
If anyone has the time I'd really appreciate it if you could have a read through and review - my intent is that this should be a complete explanation of how the MAP sensor is used. It would be great as well if you have questions about how specific values are obtained (e.g. "how do I know that xyz really does what you say it does?") then please point these out and I can do detailed listings of those things as well. It's a bit hard to figure out what the appropriate bounds of this are as you can go to the n'th degree with everything. Ideally I'd like the end result to be something that is so clear and comprehensive it leaves no remaining doubt that this is indeed the way the MAP sensor works.
Random screenshots of the wiki page to snazz up this post.
Screenshot from overview
Screenshot from function description of rf_calc()
Screenshot from code walkthrough of rf_calc()
Screenshot from code walkthrough of rf_p_kad_i_calc()
2005 ///M3 SMG Coupe Silbergrau Metallic/CSL bucket seats
Build Thread: https://nam3forum.com/forums/forum/m...e46-m3-journal
- Likes 4
Comment
-
I've also uploaded an archive ghidra project which contains all my latest work - it can be found here: https://github.com/karter16/CSL_0401...2025_03_09.gar It's a work in progress and I keep on wanting to tidy it up more before sharing but if I do that I'll never share it. You'll just need to put up with the fact that some of my comments will be out of date and the inconsistencies of work in progress. Let me know if you have any Q's.
Again my ask would be if you figure things out that you post them here as you go so that I can keep incorporating discoveries into the master disassembly project.2005 ///M3 SMG Coupe Silbergrau Metallic/CSL bucket seats
Build Thread: https://nam3forum.com/forums/forum/m...e46-m3-journal
- Likes 2
Comment
-
Amazing, thank you! The only things I've noticed are just clerical: Definitions for TAN and P_UMG don't exist on the page in the Input Variables section. You added a quick (Definition) for other variables that were referenced but don't show up directly in these functions‘02 332iT / 6 | ‘70 Jaguar XJ6 electric conversion
- Likes 1
Comment
-
Originally posted by Bry5on View PostAmazing, thank you! The only things I've noticed are just clerical: Definitions for TAN and P_UMG don't exist on the page in the Input Variables section. You added a quick (Definition) for other variables that were referenced but don't show up directly in these functions2005 ///M3 SMG Coupe Silbergrau Metallic/CSL bucket seats
Build Thread: https://nam3forum.com/forums/forum/m...e46-m3-journal
- Likes 1
Comment
-
This is brilliant. I'm still working on absorbing your written description and browsing through your project simultaneously to make sense of how you arrived at it, but writing it out like that is extremely helpful.
Another dumb question, when building a project like this did you have to populate the memory map in Ghidra or is that done automatically based on selecting the 68k architecture? I'm assuming you did, based on the nomenclature used for the memory segments.
- Likes 1
Comment
-
Originally posted by R3VM3UP View PostThis is brilliant. I'm still working on absorbing your written description and browsing through your project simultaneously to make sense of how you arrived at it, but writing it out like that is extremely helpful.
Another dumb question, when building a project like this did you have to populate the memory map in Ghidra or is that done automatically based on selecting the 68k architecture? I'm assuming you did, based on the nomenclature used for the memory segments.
Yeah we had to populate the memory map manually. There's lots of different ways to configure the 68k memory so it was built out based on the work others have done in the past, referring to the Motorola documentation, etc. It's fairly crucial to get it right as the disassembler takes the memory map into account when disassembling (e.g. if you leave program ROM marked as writable you are in for a bad time with pointer references lol because the disassembler has to assume anything could change at any time.)2005 ///M3 SMG Coupe Silbergrau Metallic/CSL bucket seats
Build Thread: https://nam3forum.com/forums/forum/m...e46-m3-journal
Comment
-
Originally posted by Bry5on View PostIn my other car.
2005 ///M3 SMG Coupe Silbergrau Metallic/CSL bucket seats
Build Thread: https://nam3forum.com/forums/forum/m...e46-m3-journal
Comment
-
Originally posted by karter16 View Post
Do you happen to have a build thread somewhere for the Jag? I would love to read it if it exists.
Here's what it looks like (not much has changed in the past four years except for stable mates): https://youtu.be/UGBo-wUDK4g
And a few details here, although I wasn't as great about updates. Not having the details was part of what motivated me to make this wagon build thread: https://www.jaguarforums.com/forum/x...roject-184994/‘02 332iT / 6 | ‘70 Jaguar XJ6 electric conversion
- Likes 1
Comment
-
Essentially RF can be adjusted for knock protection or cylinder pressure management. The integral component is suspended while this is in effect, so that it doesn't try to “adjust out” the dynamic adjustment.
Sent from my iPhone using Tapatalk2005 ///M3 SMG Coupe Silbergrau Metallic/CSL bucket seats
Build Thread: https://nam3forum.com/forums/forum/m...e46-m3-journal
Comment
-
Originally posted by Bry5on View Post
Really light on details of the Jag sadly.
Here's what it looks like (not much has changed in the past four years except for stable mates): https://youtu.be/UGBo-wUDK4g
And a few details here, although I wasn't as great about updates. Not having the details was part of what motivated me to make this wagon build thread: https://www.jaguarforums.com/forum/x...roject-184994/
Sent from my iPhone using Tapatalk2005 ///M3 SMG Coupe Silbergrau Metallic/CSL bucket seats
Build Thread: https://nam3forum.com/forums/forum/m...e46-m3-journal
- Likes 1
Comment
-
Originally posted by karter16 View Post
Hey - it's a short doc but 8.02 in the funktionsrahmen explains it https://github.com/karter16/CSL_0401...mic%20Lead.pdf
Essentially RF can be adjusted for knock protection or cylinder pressure management. The integral component is suspended while this is in effect, so that it doesn't try to “adjust out” the dynamic adjustment.
Sent from my iPhone using Tapatalk
- Likes 1
Comment
Comment